Feature/process command #3
Conversation
pipeline implemented. next steps are to include the insert-tables script (the final step for adding data into postgis table) as well as cleaning scripts that clean geometries
insert into file inserts geojson features as rows into openroads-vn database. the connection file builds the connection needed to do so
.gitignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| node_modules | |||
| **/*/.DS_store | |||
There was a problem hiding this comment.
Small thing: remove .DS_Stores that have already been committed when this line came in.
processing/e-insert-tables.js
Outdated
| geo: st.geomFromGeoJSON(geometry), | ||
| name_en: properties.en_name, | ||
| name_vn: '' | ||
| }).into(`${admin}-table`).toString(); |
There was a problem hiding this comment.
Won't all levels of boundaries live in the same admin table? That's how I have it set up, and how we did it for ORMA Philippines. With one table, it's easier to query, and self-joins make it as versatile as multiple tables (eg, SELECT child.name_en FROM admin_areas AS parent JOIN admin_areas AS child ON parent.id=child.parent_id WHERE parent.id='12345'). Plus, then it's portable to different countries (which would have different names for their admin levels).
There was a problem hiding this comment.
For sure they can all live in the same table / they need to if that is how you have things set up! I'll make the changes to that script we're doing the right insert.
the 'delete holes' module has been added to the pipeline. next to be added is the initial cleaning module
There was a problem hiding this comment.
Looks good in general, especially if you've gone over it thoroughly with @kamicut. Left a couple notes.
pipeline is now running with the fill holes step.
Feature/clean geometries
|
There's not time right now to review this huge PR, nor can Max make changes to it. Devseed can make tweaks down the road if needed, and @sarahantos is also promising us a better source shapefile which might obviate this! |
...the cleaning steps within the pipeline that handle geometry issues still need to be added.
However, given the modularity of the pipeline and usefulness of feedback, its a good time for a pr.
I will make the branch for cleaning a branch off of this branch.